Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/191269 change grant comms #757

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Feature/191269 change grant comms #757

merged 1 commit into from
Dec 10, 2024

Conversation

mshakirdfe
Copy link
Contributor

dangood84
dangood84 previously approved these changes Dec 10, 2024
View reviewed changes
dangood84
dangood84 previously approved these changes Dec 10, 2024
View reviewed changes
DrizzlyOwl
DrizzlyOwl reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the code, but I had a minor comment on the appsettings. Otherwise is fine

@mshakirdfe mshakirdfe force-pushed the feature/191269-change-grant-comms branch from da10a0f to eec8141 Compare December 10, 2024 16:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.1% Coverage on New Code (required ≥ 70%)
10 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

DrizzlyOwl
DrizzlyOwl approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be better if we can improve the code coverage as suggested by Sonar :)

@mshakirdfe mshakirdfe merged commit e174a28 into master Dec 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangood84 dangood84 dangood84 approved these changes

@DrizzlyOwl DrizzlyOwl DrizzlyOwl approved these changes

@paullocknimble paullocknimble Awaiting requested review from paullocknimble

@FahadDarw FahadDarw Awaiting requested review from FahadDarw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshakirdfe @DrizzlyOwl @dangood84